damccorm commented on code in PR #38871:
URL: https://github.com/apache/beam/pull/38871#discussion_r3405085081
##########
sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/impl/transform/agg/VarianceFn.java:
##########
@@ -95,11 +99,21 @@ public static VarianceFn newSample(Schema.TypeName
typeName) {
public static <V extends Number> VarianceFn newSample(
SerializableFunction<BigDecimal, V> decimalConverter) {
- return new VarianceFn<>(SAMPLE, decimalConverter);
+ return new VarianceFn<>(SAMPLE, false, decimalConverter);
}
- private VarianceFn(boolean isSample, SerializableFunction<BigDecimal, T>
decimalConverter) {
+ public static VarianceFn newSampleStddev(Schema.TypeName typeName) {
+ return new VarianceFn<>(SAMPLE, true,
BigDecimalConverter.forSqlType(typeName));
+ }
+
+ public static VarianceFn newPopulationStddev(Schema.TypeName typeName) {
+ return new VarianceFn<>(POP, true,
BigDecimalConverter.forSqlType(typeName));
+ }
Review Comment:
We don't need this for now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
