gemini-code-assist[bot] commented on code in PR #38981:
URL: https://github.com/apache/beam/pull/38981#discussion_r3419565284
##########
sdks/python/apache_beam/io/gcp/bigquery_file_loads.py:
##########
@@ -607,7 +607,7 @@ def _determine_write_disposition(self, copy_to_reference)
-> tuple[bool, str]:
copy_to_reference.tableId)
if full_table_ref not in self._observed_tables:
write_disposition = self.write_disposition
- wait_for_job = True
+ wait_for_job = (self.write_disposition != 'WRITE_APPEND')
Review Comment:
To avoid using hardcoded string literals and maintain consistency with the
rest of the codebase, please use the `BigQueryDisposition.WRITE_APPEND`
constant instead of the `'WRITE_APPEND'` string literal.
```suggestion
wait_for_job = (self.write_disposition !=
BigQueryDisposition.WRITE_APPEND)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
