gemini-code-assist[bot] commented on code in PR #38960:
URL: https://github.com/apache/beam/pull/38960#discussion_r3420083347
##########
runners/google-cloud-dataflow-java/src/main/java/org/apache/beam/runners/dataflow/options/DataflowWorkerLoggingOptions.java:
##########
@@ -30,13 +30,11 @@
/**
* Options that are used to control logging configuration on the Dataflow
worker.
*
- * @deprecated This interface will no longer be the source of truth for worker
logging configuration
- * once jobs are executed using a dedicated SDK harness instead of user
code being co-located
- * alongside Dataflow worker code. Consider set corresponding options
within {@link
- * org.apache.beam.sdk.options.SdkHarnessOptions} to ensure forward
compatibility.
+ * <p>Some options in this interface are no longer the source of truth for
worker logging
+ * configuration. Consider using the corresponding options within {@link
+ * org.apache.beam.sdk.options.SdkHarnessOptions} to ensure compatibility with
other runners.
Review Comment:
Since all options defined in this interface (`getDefaultWorkerLogLevel`,
`getWorkerSystemOutMessageLevel`, `getWorkerSystemErrMessageLevel`, and
`getWorkerLogLevelOverrides`) are deprecated in favor of `SdkHarnessOptions`,
stating that "Some options" are no longer the source of truth is misleading. It
is clearer to state that "The options" or "All options" in this interface are
deprecated.
```suggestion
* <p>The options in this interface are no longer the source of truth for
worker logging
* configuration. Consider using the corresponding options within {@link
* org.apache.beam.sdk.options.SdkHarnessOptions} to ensure compatibility
with other runners.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
