stankiewicz opened a new pull request, #38983: URL: https://github.com/apache/beam/pull/38983
Fixes: https://github.com/apache/beam/issues/38982 #### Description This PR optimizes BigQuery copy jobs in the Python SDK's file loads path by utilizing BigQuery's multi-source copy feature. Instead of triggering a separate copy job for each temporary table, we now group them and trigger a single copy job with up to 1,200 sources (BigQuery limit). #### Key Changes • Multi-source Copy Support: Updated BigQueryWrapper._insert_copy_job to accept a list of source tables and construct the API request with sourceTables when multiple sources are provided. • Batch Copying: Re-implemented TriggerCopyJobs to process temporary tables in batch per destination, splitting them into chunks of 1,200 and using multi-source copy. • Truncate/Empty Handling: Implemented inline wait for the first chunk copy job when using WRITE_TRUNCATE or WRITE_EMPTY with multiple chunks. This ensures the destination table is correctly initialized (truncated/verified empty) before subsequent chunks append data to it. • Grouping Key Fix: Fixed a bug in _load_data where tables with the same name in different datasets would be incorrectly grouped together because the grouping key was only tableId . It now uses the full hashable_destination . • Test Cleanups & Additions: • Added test_copy_jobs_splitting to verify the splitting logic and inline wait logic. • Updated existing tests to match the new behavior (fewer copy jobs). • Fixed credential warnings in TriggerLoadJobs during testing by using the correct mocked client wrapper. • Fixed PartitionFiles to avoid generating empty partitions. ------------------------ Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead. - [ ] Update `CHANGES.md` with noteworthy changes. - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://github.com/apache/beam/blob/master/CONTRIBUTING.md#make-the-reviewers-job-easier). To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md) GitHub Actions Tests Status (on master branch) ------------------------------------------------------------------------------------------------ [](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule) [](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule) [](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule) [](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule) See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI or the [workflows README](https://github.com/apache/beam/blob/master/.github/workflows/README.md) to see a list of phrases to trigger workflows. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
