gemini-code-assist[bot] commented on code in PR #38990:
URL: https://github.com/apache/beam/pull/38990#discussion_r3428766572
##########
sdks/python/scripts/run_integration_test.sh:
##########
@@ -257,7 +264,9 @@ if [[ -z $PIPELINE_OPTS ]]; then
fi
PIPELINE_OPTS=$(IFS=" " ; echo "${opts[*]}")
-
+ if [[ -n $ADDITIONAL_OPTS ]]; then
+ PIPELINE_OPTS+=" ${ADDITIONAL_OPTS}"
+ fi
fi
Review Comment:
Currently, `ADDITIONAL_OPTS` is only appended when `PIPELINE_OPTS` is empty
(inside the `if [[ -z $PIPELINE_OPTS ]]` block). If a user or task explicitly
provides `--pipeline_opts`, any `--additional_opts` will be silently ignored.
Moving this check outside the `if` block ensures that `additional_opts` are
always appended as described in the documentation.
```suggestion
fi
if [[ -n $ADDITIONAL_OPTS ]]; then
PIPELINE_OPTS="${PIPELINE_OPTS:+$PIPELINE_OPTS }$ADDITIONAL_OPTS"
fi
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
