gemini-code-assist[bot] commented on code in PR #39016:
URL: https://github.com/apache/beam/pull/39016#discussion_r3435934970
##########
sdks/java/io/rrio/src/test/java/org/apache/beam/io/requestresponse/CallTest.java:
##########
@@ -397,16 +397,16 @@ private static class SetupExceedsTimeout implements
SetupTeardown {
private final Duration timeout;
private SetupExceedsTimeout(Duration timeout) {
- this.timeout = timeout.plus(Duration.standardSeconds(1L));
+ this.timeout = timeout.plus(Duration.standardMinutes(1L));
Review Comment:
Increasing the sleep duration by a full minute can cause the test suite to
hang or run extremely slowly if the timeout execution fails to interrupt
properly or if there is a regression. A smaller buffer, such as 5 or 10
seconds, is typically sufficient to prevent flakiness on busy CI machines while
keeping test failures fast.
```suggestion
this.timeout = timeout.plus(Duration.standardSeconds(5L));
```
##########
sdks/java/io/rrio/src/test/java/org/apache/beam/io/requestresponse/CallTest.java:
##########
@@ -436,28 +436,28 @@ public void setup() throws UserCodeExecutionException {
}
@Override
- public void teardown() throws UserCodeExecutionException {}
+ public void teardown() {}
}
private static class TeardownExceedsTimeout implements SetupTeardown {
private final Duration timeout;
private TeardownExceedsTimeout(Duration timeout) {
- this.timeout = timeout.plus(Duration.standardSeconds(1L));
+ this.timeout = timeout.plus(Duration.standardMinutes(1L));
Review Comment:
Increasing the sleep duration by a full minute can cause the test suite to
hang or run extremely slowly if the timeout execution fails to interrupt
properly or if there is a regression. A smaller buffer, such as 5 or 10
seconds, is typically sufficient to prevent flakiness on busy CI machines while
keeping test failures fast.
```suggestion
this.timeout = timeout.plus(Duration.standardSeconds(5L));
```
##########
sdks/java/io/rrio/src/test/java/org/apache/beam/io/requestresponse/CallTest.java:
##########
@@ -358,11 +358,11 @@ private static class CallerExceedsTimeout implements
Caller<Request, Response> {
private final Duration timeout;
CallerExceedsTimeout(Duration timeout) {
- this.timeout = timeout.plus(Duration.standardSeconds(1L));
+ this.timeout = timeout.plus(Duration.standardMinutes(1L));
Review Comment:
Increasing the sleep duration by a full minute can cause the test suite to
hang or run extremely slowly if the timeout execution fails to interrupt
properly or if there is a regression. A smaller buffer, such as 5 or 10
seconds, is typically sufficient to prevent flakiness on busy CI machines while
keeping test failures fast.
```suggestion
this.timeout = timeout.plus(Duration.standardSeconds(5L));
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
