Shri-Vardhan commented on issue #38587:
URL: https://github.com/apache/beam/issues/38587#issuecomment-4743817933

   Closing this PR because `KafkaCommitOffset.CommitOffsetDoFn` already logs 
commit failures and retry attempts. 
   
   I reviewed the existing behavior in KafkaCommitOffset.CommitOffsetDoFn, and 
noticed that commit failures and retry attempts are already adequately captured 
through the current logging.
   
   Given that, adding Beam metrics here would provide overlapping observability 
with limited additional value while increasing maintenance complexity. 
   
   I don't have further concerns, so I'm happy with closing this issue.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to