piotr-szuberski edited a comment on pull request #12838:
URL: https://github.com/apache/beam/pull/12838#issuecomment-700676777


   There is a problem here though. The checker says to use vendored proto 
library but the extensions/protobuf uses the normal one. How is that possible 
that it's fine there and it's a bug in extensions/sql?
   And for example ProtoCoder<T> requires T to extend 
com.google.protobuf.Message while this is forbidden.
   Should I create another PR replacing normal protobuf library with the 
vendored one in extensions/protobuf or is there a reason not to use vendored 
grpc library there?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to