reuvenlax commented on code in PR #38988:
URL: https://github.com/apache/beam/pull/38988#discussion_r3438504183
##########
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/StreamingKeyedWorkItemSideInputParDoFn.java:
##########
@@ -208,7 +190,7 @@ public void abort() throws Exception {
}
protected void onProcessWindowedValue(WindowedValue<KeyedWorkItem<K,
InputT>> elem) {
- // TODO: Get rid of this!
+ // TODO: Get rid of this once we know the current key.
final K key = elem.getValue().key();
Review Comment:
Yes - it's update compatible, it just means that we won't support
downgrading the Beam version.
I also considered adding code to delete the key state if it's there, but I
think it's best not to
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
