gemini-code-assist[bot] commented on code in PR #39035:
URL: https://github.com/apache/beam/pull/39035#discussion_r3444379400
##########
sdks/java/extensions/sql/iceberg/src/main/java/org/apache/beam/sdk/extensions/sql/meta/provider/iceberg/IcebergMetastore.java:
##########
@@ -116,6 +116,10 @@ public Map<String, Table> getTables() {
return table;
}
+ private String tableName(String tableId) {
+ return TableName.create(tableId).getTableName();
+ }
Review Comment:
According to the Google Java Style Guide (Section 5.2.6), method names
should typically be a verb or verb phrase (e.g., `extractTableName` or
`getTableName`) rather than a noun like `tableName`. Renaming this method
improves readability and adheres to standard Java naming conventions. Please
also update the callers at lines 97 and 140.
```suggestion
private String extractTableName(String tableId) {
return TableName.create(tableId).getTableName();
}
```
<details>
<summary>References</summary>
1. Google Java Style Guide Section 5.2.6: Method names are typically written
in lowerCamelCase. A method name is typically a verb or verb phrase.
<sup>([link](https://github.com/apache/beam/blob/master/.gemini/styleguide.md))</sup>
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
