wilmerdooley commented on PR #38751: URL: https://github.com/apache/beam/pull/38751#issuecomment-4771422319
Thanks @Abacn. Reworked as you suggested: the deferral now lives in `gcsio` via a module-level `GOOGLE_CLOUD_STORAGE_INSTALLED` flag (mirroring the `BOTO3_INSTALLED` flag in `s3io`), so `gcsio` imports without the gcp extra and the dependency error is raised at `GcsIO` creation instead. I reverted the `gcsfilesystem` lazy-import plumbing, so that file is back to a plain `gcsio` import like `s3filesystem`, and added a `gcsio` test for the no-extra path. Happy to adjust if you would prefer anything different. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
