gemini-code-assist[bot] commented on code in PR #39077:
URL: https://github.com/apache/beam/pull/39077#discussion_r3463481018
##########
runners/flink/job-server/flink_job_server.gradle:
##########
@@ -248,10 +248,26 @@ def setupTask =
project.tasks.register("flinkJobServerSetup", Exec) {
def flinkJobServerJar = shadowJar.archivePath
def flinkDir = project.project(":runners:flink").projectDir
def additionalArgs = ""
- if (project.hasProperty('flinkConfDir'))
+
+ if (project.hasProperty('flinkConfDir')) {
additionalArgs += " --flink-conf-dir=${project.property('flinkConfDir')}"
- else
+ }
+ else if (isFlink2) {
+ def flinkConfDir = "$flinkDir/2.0/src/test/resources"
+ additionalArgs += "--flink-conf-dir=${project.buildDir}/flink-conf"
+
+ doFirst {
+ copy {
+ from "$flinkDir/2.0/src/test/resources/flink-test-config.yaml"
Review Comment:
The variable `flinkConfDir` is defined but not used in the `from` path of
the copy task, resulting in a duplicated string literal. Additionally, adding a
leading space to `additionalArgs` ensures consistency with other branches.
```
def flinkConfDir = "$flinkDir/2.0/src/test/resources"
additionalArgs += " --flink-conf-dir=${project.buildDir}/flink-conf"
doFirst {
copy {
from "$flinkConfDir/flink-test-config.yaml"
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
