bradmiro commented on pull request #12963: URL: https://github.com/apache/beam/pull/12963#issuecomment-700873996
This looks great! A couple notes: I haven't commonly seen **with** blocks used in examples for the sparkContext. Though it should technically work, I might remove it in favor of just `sc = spark.SparkContext()`. You may also want to make some mention of the Spark `DataFrame` [API](https://spark.apache.org/docs/latest/api/python/pyspark.sql.html#pyspark.sql.DataFrame), at least in the introduction. This is technically newer and in many cases superior to the RDD API, and where a lot of users would be coming from. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
