Abacn commented on code in PR #39052:
URL: https://github.com/apache/beam/pull/39052#discussion_r3464439706
##########
.github/workflows/beam_PostCommit_Yaml_Xlang_Direct.yml:
##########
@@ -75,8 +75,8 @@ jobs:
with:
python-version: default
java-version: |
- 17
Review Comment:
"11 17" is effectively same as "17". Either change to 17 (and remove
java17Home parameter) or add a "testJavaVersion=17" parameter and make the
target honors it (like in
https://github.com/apache/beam/pull/39064/changes#diff-0435a83a413ec063bf7e682cadcd56776cd18fc878f197cc99a65fc231ef2047)
##########
.github/workflows/beam_PreCommit_Xlang_Generated_Transforms.yml:
##########
@@ -103,8 +103,8 @@ jobs:
uses: ./.github/actions/setup-environment-action
with:
java-version: |
- 17
11
+ 17
Review Comment:
Same as above
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
