derrickaw commented on code in PR #38711: URL: https://github.com/apache/beam/pull/38711#discussion_r3468659817
########## .github/workflows/beam_Upgrade_GCP_BOM.yml: ########## @@ -0,0 +1,85 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +name: Upgrade GCP Libraries BOM + +on: + schedule: + - cron: "0 0 * * 0" # Weekly on Sundays at 00:00 UTC Review Comment: > Today we only update this right after releases - https://github.com/apache/beam/blob/master/contributor-docs/release-guide.md#update-the-java-bom - this is somewhat intentional since BOM upgrades tend to be: > > 1. Higher risk > 2. Lower urgency (rarely are features blocked on this) > > I think we probably want to keep this behavior. > I knew about the timing, but if I understand the flow of things some package versions that have vulnerabilities are dependent on this BOM being updated. So the main drivers for this workflow are consistently having a weekly upgrade to minimize vulnerabilities, having a process in place so that we don't forget to do the upgrade, and having a workflow if we wanted to at any given point in time just run it and have a new PR ready to go without having to do anything locally. I will go in the direction you suggest below, but I think in the future we should consider completing this upgrade more often. > We could probably do something like what we do for Python dependencies - https://github.com/apache/beam/blob/master/contributor-docs/release-guide.md#update-python-dependencies > > At that point, we'd need to: > > 1. Add logic like https://github.com/apache/beam/blob/63bcd3dd2b5d54261de386ad388e2d576913e525/.github/workflows/update_python_dependencies.yml#L87 > to this file > 2. Update the release guide to have instructions similar to https://github.com/apache/beam/blob/master/contributor-docs/release-guide.md#update-python-dependencies Ok, updated. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
