vectorijk commented on a change in pull request #12962:
URL: https://github.com/apache/beam/pull/12962#discussion_r496964747
##########
File path: vendor/calcite-1_25_0/build.gradle
##########
@@ -18,29 +18,33 @@
plugins { id 'org.apache.beam.vendor-java' }
-description = "Apache Beam :: Vendored Dependencies :: Calcite 1.20.0"
+description = "Apache Beam :: Vendored Dependencies :: Calcite 1.25.0"
group = "org.apache.beam"
version = "0.2"
Review comment:
let's start from 0.1?
##########
File path: vendor/calcite-1_25_0/build.gradle
##########
@@ -18,29 +18,33 @@
plugins { id 'org.apache.beam.vendor-java' }
-description = "Apache Beam :: Vendored Dependencies :: Calcite 1.20.0"
+description = "Apache Beam :: Vendored Dependencies :: Calcite 1.25.0"
group = "org.apache.beam"
version = "0.2"
-def calcite_version = "1.20.0"
+def calcite_version = "1.25.0"
def avatica_version = "1.16.0"
-def prefix = "org.apache.beam.vendor.calcite.v1_20_0"
+def prefix = "org.apache.beam.vendor.calcite.v1_25_0"
List<String> packagesToRelocate = [
"com.esri",
+ "com.fasterxml",
"com.google.common",
- "com.google.thirdparty",
"com.google.protobuf",
- "com.fasterxml",
+ "com.google.thirdparty",
"com.jayway",
"com.yahoo",
+ "javax.annotation",
+ "net.minidev",
"org.apache.calcite",
"org.apache.commons",
"org.apache.http",
+ "org.apiguardian.api",
"org.codehaus",
+ "org.objectweb",
"org.pentaho",
- "org.yaml"
+ "org.yaml",
]
vendorJava(
Review comment:
some logging libraries need to be put into runtimeDepencies. for you
reference:
https://github.com/vectorijk/beam/blob/calcite-1-25/vendor/calcite-1_25_0/build.gradle
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
