Abacn commented on code in PR #39107:
URL: https://github.com/apache/beam/pull/39107#discussion_r3475531554


##########
sdks/python/apache_beam/io/gcp/bigquery_file_loads.py:
##########
@@ -589,9 +596,7 @@ def process(
         write_disposition = 'WRITE_APPEND'
         wait_for_job = False
 
-      chunk_job_name = copy_job_name_base
-      if len(chunks) > 1:
-        chunk_job_name = f"{copy_job_name_base}_{i}"
+      chunk_job_name = '%s_%s' % (copy_job_name_base, _bq_uuid_list(chunk))

Review Comment:
   We have to be careful here. I remember bq load job being deterministic is 
intended to avoid duplicate data on retry.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to