ahmedabu98 commented on code in PR #38836:
URL: https://github.com/apache/beam/pull/38836#discussion_r3477458788
##########
sdks/java/io/iceberg/src/main/java/org/apache/beam/sdk/io/iceberg/IcebergScanConfig.java:
##########
@@ -144,6 +150,25 @@ public org.apache.iceberg.Schema getRequiredSchema() {
return cachedRequiredSchema;
}
+ public org.apache.iceberg.Schema recordIdSchema() {
+ if (cachedRecordIdSchema == null) {
+ org.apache.iceberg.Schema fullSchema = getTable().schema();
+ cachedRecordIdSchema = TypeUtil.select(fullSchema,
fullSchema.identifierFieldIds());
+ }
+ return cachedRecordIdSchema;
+ }
Review Comment:
Validation is already in IcebergScanConfig
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
