ash6898 commented on PR #38252: URL: https://github.com/apache/beam/pull/38252#issuecomment-4824484204
Apologies for the delayed response — I've been away for the past two weeks. I've now addressed the review feedback: Restored the !hasExperiment(options, "upload_graph") guard so the log only fires when the experiment is newly added, not when it was already present. Also fixed addExperiment() itself in ExperimentalOptions to always copy the list into a fresh mutable ArrayList (handling both null and immutable list cases), which makes the call-site defensive copies genuinely redundant. cc @tvalentyn — you had previously approved, but I pushed two small follow-up commits addressing your feedback. Happy to have you re-review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
