PDGGK commented on PR #37342: URL: https://github.com/apache/beam/pull/37342#issuecomment-4830219397
Friendly ping — this one's been waiting on review since February and CI is green / the branch is mergeable. The questions @kennknowles raised earlier are resolved: per the feedback I simplified `parseAndThrow` to inspect `e.getCause()` once (`Future.get()` adds exactly one `ExecutionException` wrapper) — if the cause is a `UserCodeExecutionException` or subclass it's rethrown as-is so `shouldRepeat()` still sees the retryable type, otherwise it's wrapped once. That's in commit `5ff10ae` and the tests were updated to match. @chamikaramj @Abacn @kennknowles could one of you take a look when you have a chance? Happy to make any further changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
