stankiewicz commented on code in PR #39152:
URL: https://github.com/apache/beam/pull/39152#discussion_r3492773686
##########
sdks/java/core/src/main/java/org/apache/beam/sdk/values/WindowedValues.java:
##########
@@ -200,7 +200,9 @@ public Instant getTimestamp() {
@Override
public @Nullable Context getOpenTelemetryContext() {
- return openTelemetryContext;
+ // builder may have different context set at the beginning of parDo
+ // when building WindowedValue we should take current context from
storage.
+ return openTelemetryContext != Context.current() ? Context.current() :
openTelemetryContext;
Review Comment:
good point but usage is from within the thread that is having the proper
context.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
