nikitagrover19 opened a new pull request, #39160:
URL: https://github.com/apache/beam/pull/39160
Schema cannot be auto-derived from a table when a query is used, so this
adds an explicit query_output_schema param for that case.
Fixes #36988
**Problem**
BEAM_ROW output was disallowed with query= since schema can't be derived
from a table when there's no table. This blocked the YAML transform from using
BEAM_ROW with queries.
**Change**
Adds an optional query_output_schema param to ReadFromBigQuery, used
directly as the row schema when set. YAML's read_from_bigquery() exposes this
as schema, required when query is set. Backward compatible, table-based reads
unaffected.
**Testing**
Unit tests cover constructor validation, schema pass-through, and that
get_table() is skipped when query_output_schema is supplied. Not covered:
correctness of convert_to_usertype output against a real query execution -
would need a live BQ connection or a heavier fake.
**Known testing gap**
These tests verify the schema is passed through and used (i.e.,
convert_to_usertype is called with the right arguments, and get_table is
correctly skipped). They do not verify that convert_to_usertype produces
correct Beam Rows at runtime from a real query execution, that would require
either a live BigQuery connection or a more substantial fake of the
job-execution lifecycle. Open to adding that if reviewers feel it's necessary
for merge.
------------------------
Thank you for your contribution! Follow this checklist to help us
incorporate your contribution quickly and easily:
- [x] Mention the appropriate issue in your description (for example:
`addresses #123`), if applicable. This will automatically add a link to the
pull request in the issue. If you would like the issue to automatically close
on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual
Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more
tips on [how to make review process
smoother](https://github.com/apache/beam/blob/master/CONTRIBUTING.md#make-the-reviewers-job-easier).
To check the build health, please visit
[https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more
information about GitHub Actions CI or the [workflows
README](https://github.com/apache/beam/blob/master/.github/workflows/README.md)
to see a list of phrases to trigger workflows.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
