aIbrahiim commented on code in PR #39162:
URL: https://github.com/apache/beam/pull/39162#discussion_r3496966159
##########
sdks/python/apache_beam/examples/ml_transform/mltransform_one_hot_encoding_test.py:
##########
@@ -140,7 +137,6 @@ def test_end_to_end_pipeline_local(self):
self.assertIn('color', record)
self.assertIn('size', record)
- @pytest.mark.uses_tft
def test_pipeline_with_missing_columns(self):
Review Comment:
uses_tft selects tests for the Dataflow TFT job (-m uses_tft) not
skip-without-TFT and missing TFT is already handled by the module-level
SkipTest on import so these two tests are local DirectRunner tests (local /tmp
I/O) and keeping uses_tft caused them to run on Dataflow and fail on output
file assertions so removing the marker excludes them from tftTests only, they
remain valid local tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
