derrickaw commented on PR #38772: URL: https://github.com/apache/beam/pull/38772#issuecomment-4845292625
> LGTM for the scope of this PR. > > But I think ideally we wouldn't need to handicap the Python implementation just to match the available Java config -- those features could be of interest to users. > > Would be good to get an idea of whether YAML switches to an implementation that accommodates config parameters. I forgot about the detail that the parameters need to match based on Jeff's Normalization guide until you brought it up again - `It can be seen that normalizing the transform was as simple as adding some validation and only exposing the 4 parameters that are important to YAML. Keep in mind that these parameters should line up with their Java counterparts, so if the Python implementation has a parameter that does not exist on the Java implementation, it either needs to be added to the Java implementation, or hidden from the normalized python version.` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
