derrickaw commented on code in PR #39174:
URL: https://github.com/apache/beam/pull/39174#discussion_r3500313394
##########
sdks/java/core/src/test/java/org/apache/beam/sdk/io/FileIOTest.java:
##########
@@ -291,23 +328,29 @@ public void testMatchWatchForNewFiles() throws
IOException, InterruptedException
.filepattern(watchPath.resolve("*").toString())
.continuously(
Duration.millis(100),
-
Watch.Growth.afterTimeSinceNewOutput(Duration.standardSeconds(1))));
+ Watch.Growth.eitherOf(
+ new AfterNumberOfNewOutputs(numFiles),
+
Watch.Growth.afterTimeSinceNewOutput(Duration.standardSeconds(10)))));
PCollection<MatchResult.Metadata> matchAllMetadata =
p.apply("create for matchAll new files",
Create.of(watchPath.resolve("*").toString()))
.apply(
"match filename through matchAll",
FileIO.matchAll()
.continuously(
Duration.millis(100),
-
Watch.Growth.afterTimeSinceNewOutput(Duration.standardSeconds(1))));
+ Watch.Growth.eitherOf(
+ new AfterNumberOfNewOutputs(numFiles),
+
Watch.Growth.afterTimeSinceNewOutput(Duration.standardSeconds(10)))));
PCollection<MatchResult.Metadata> matchUpdatedMetadata =
p.apply(
"match updated",
FileIO.match()
.filepattern(watchPath.resolve("first").toString())
.continuously(
Duration.millis(100),
-
Watch.Growth.afterTimeSinceNewOutput(Duration.standardSeconds(1)),
+ Watch.Growth.eitherOf(
+ new AfterNumberOfNewOutputs(numFiles),
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
