Abacn commented on code in PR #38729:
URL: https://github.com/apache/beam/pull/38729#discussion_r3502867463
##########
sdks/java/io/mqtt/build.gradle:
##########
@@ -19,6 +19,19 @@
plugins { id 'org.apache.beam.module' }
applyJavaNature( automaticModuleName: 'org.apache.beam.sdk.io.mqtt')
+// The JMS IO module pulls ActiveMQ 6.2.5 (Java 17) into the shared dependency
+// map. Because the global resolution strategy forces every mapped version,
+// that 6.2.5 would otherwise be forced onto this Java 11 module via the shared
+// org.apache.activemq coordinates. MQTT IO only needs ActiveMQ as an embedded
+// test broker, so pin it back to the Java 11-compatible 5.x line.
Review Comment:
ActiveMQ is a test dependency for AmqpIO, MqttIO, JmsIO. Instead of
modifying build.gradle in the former ones, can we just pin to ActiveMQ 6 in
JmsIO? This should give a smaller diff and safer as it doesn't do a global
upgrade.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
