ahmedabu98 commented on code in PR #38833:
URL: https://github.com/apache/beam/pull/38833#discussion_r3509206812
##########
sdks/python/apache_beam/io/gcp/bigquery_file_loads.py:
##########
@@ -758,6 +808,11 @@ def process(
job_name,
e)
Review Comment:
```suggestion
elif destination_table is not None:
schema = bigquery_tools.table_schema_to_dict(
destination_table.schema)
self.schema_cache[hashed_dest] = schema
```
We can probable remove this try-catch? It was originally meant for the
`get_table()` call
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]