ath-08 opened a new pull request, #39241:
URL: https://github.com/apache/beam/pull/39241
This change allows Beam pipeline developers to configure Cloud Spanner
DirectedReadOptions on SpannerConfig, as well as on SpannerIO.read(),
readAll(), and readChangeStream().
- Adds getDirectedReadOptions() and withDirectedReadOptions(...) overloads
(accepting DirectedReadOptions, ValueProvider<DirectedReadOptions>, and String)
to SpannerConfig.
- Adds an internal parseDirectedReadOptions helper supporting both standard
JSON strings and shorthand <location>:<type> strings (e.g.
us-central1:READ_ONLY).
- Threads DirectedReadOptions into SpannerOptions.Builder in SpannerAccessor
so that all DatabaseClient instances and ChangeStreamDao queries automatically
inherit the directed read configuration.
- Adds delegation methods to SpannerIO.Read, ReadAll, and ReadChangeStream.
- Adds comprehensive unit tests in SpannerAccessorTest and
SpannerIOReadChangeStreamTest.
**Please** add a meaningful description for your change here
------------------------
Thank you for your contribution! Follow this checklist to help us
incorporate your contribution quickly and easily:
- [ ] Mention the appropriate issue in your description (for example:
`addresses #123`), if applicable. This will automatically add a link to the
pull request in the issue. If you would like the issue to automatically close
on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual
Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more
tips on [how to make review process
smoother](https://github.com/apache/beam/blob/master/CONTRIBUTING.md#make-the-reviewers-job-easier).
To check the build health, please visit
[https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more
information about GitHub Actions CI or the [workflows
README](https://github.com/apache/beam/blob/master/.github/workflows/README.md)
to see a list of phrases to trigger workflows.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
