Abacn commented on code in PR #39253:
URL: https://github.com/apache/beam/pull/39253#discussion_r3548064684
##########
sdks/java/io/jms/src/main/java/org/apache/beam/sdk/io/jms/JmsCheckpointMark.java:
##########
@@ -93,14 +100,37 @@ public void finalizeCheckpoint() {
LOG.info("Error closing JMS session. It may have already been
closed.");
}
}
+
+ if (activeCheckpoints != null) {
+ activeCheckpoints.decrementAndGet();
+ }
Review Comment:
Too defensive in opposite direction. Over estimate count is fine but we must
not underestimate count. We only guarantee when the count is zero, there isn't
active checkpoint.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
