damccorm commented on code in PR #39292:
URL: https://github.com/apache/beam/pull/39292#discussion_r3564179008
##########
model/pipeline/src/main/proto/org/apache/beam/model/pipeline/v1/external_transforms.proto:
##########
@@ -60,36 +60,50 @@ message ExpansionMethods {
}
// Defines the URNs for managed transforms.
+// Managed transforms are high-level, pre-configured transforms that map to
+// specific SchemaTransform implementations. They provide a convenient way
+// to use common I/O patterns without specifying the full transform details.
Review Comment:
```suggestion
// Managed transforms are high-level, pre-configured transforms that map to
// specific SchemaTransform implementations. They provide a way to
// to use common I/O patterns without worrying about Beam version.
// See https://beam.apache.org/documentation/io/managed-io/
```
##########
model/pipeline/src/main/proto/org/apache/beam/model/pipeline/v1/beam_runner_api.proto:
##########
@@ -1598,24 +1651,42 @@ message StandardEnvironments {
}
}
-// The payload of a Docker image
+// Payload for a Docker container environment.
+// The container image is assumed to be linux_amd64.
Review Comment:
```suggestion
// Payload for a Docker container environment.
```
That's not necessarily right, it depends on the platform
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
