gemini-code-assist[bot] commented on code in PR #38047:
URL: https://github.com/apache/beam/pull/38047#discussion_r3578767008
##########
sdks/java/core/src/test/java/org/apache/beam/sdk/io/FileIOTest.java:
##########
@@ -249,16 +249,25 @@ public void processElement(ProcessContext context,
@StateId("count") ValueState<
context.output(Objects.requireNonNull(context.element()).getValue());
CopyOption[] cpOptions = {StandardCopyOption.COPY_ATTRIBUTES};
- CopyOption[] updOptions = {StandardCopyOption.REPLACE_EXISTING};
+ CopyOption[] updOptions = {
+ StandardCopyOption.REPLACE_EXISTING, StandardCopyOption.COPY_ATTRIBUTES
+ };
final Path sourcePath = Paths.get(sourcePathStr);
final Path watchPath = Paths.get(watchPathStr);
if (0 == current) {
Thread.sleep(100);
+ // Ensure overwrite updates get a distinct mtime even when
COPY_ATTRIBUTES is enabled.
+ Files.setLastModifiedTime(
+ sourcePath.resolve("first"),
FileTime.fromMillis(System.currentTimeMillis() + 2000));
Files.copy(sourcePath.resolve("first"), watchPath.resolve("first"),
updOptions);
Files.copy(sourcePath.resolve("second"), watchPath.resolve("second"),
cpOptions);
} else if (1 == current) {
Thread.sleep(100);
+ Files.setLastModifiedTime(
+ sourcePath.resolve("first"),
FileTime.fromMillis(System.currentTimeMillis() + 4000));
+ Files.setLastModifiedTime(
+ sourcePath.resolve("second"),
FileTime.fromMillis(System.currentTimeMillis() + 4000));
Review Comment:
Evaluating `System.currentTimeMillis()` twice can result in slightly
different timestamps for the two files if the system clock ticks over between
the calls. To ensure both files are updated with the exact same timestamp,
evaluate `System.currentTimeMillis()` once and reuse the value.
```suggestion
long now = System.currentTimeMillis();
Files.setLastModifiedTime(
sourcePath.resolve("first"), FileTime.fromMillis(now + 4000));
Files.setLastModifiedTime(
sourcePath.resolve("second"), FileTime.fromMillis(now + 4000));
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
