junaiddshaukat commented on PR #39273: URL: https://github.com/apache/beam/pull/39273#issuecomment-4971180804
> This is nearly perfect with few points: a) we should resolve the open comments (either commenting on why we think it needs to action, or take an action and resolve or comment on them) b) the WatermarkAggregator definitely deserves its own test suite so that we can explicitly test all corner cases on this separate class > > Thanks for the good work! Thanks! Added the WatermarkAggregator test suite (holds across upstreams and partitions, min aggregation, monotonicity, duplicate broadcasts, terminal MAX, repartition re-opening the hold, unexpected-transform fail-fast) and the null-payload handling, warn and drop in all four payload-consuming processors. Also went through the open threads and resolved them with a note each. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
