Abacn commented on code in PR #39253:
URL: https://github.com/apache/beam/pull/39253#discussion_r3580578679
##########
sdks/java/io/jms/src/main/java/org/apache/beam/sdk/io/jms/JmsIO.java:
##########
@@ -484,6 +510,23 @@ public Read<T> withRequiresDeduping() {
return builder().setRequiresDeduping(true).build();
}
+ /** Specify the {@link AcknowledgeMode} used for consuming and
acknowledging JMS messages. */
+ public Read<T> withAcknowledgeMode(AcknowledgeMode acknowledgeMode) {
+ checkArgument(acknowledgeMode != null, "acknowledgeMode can not be
null");
+ return builder().setAcknowledgeMode(acknowledgeMode).build();
+ }
+
+ /**
+ * Specify the custom integer code for individual message acknowledgment
when using {@link
+ * AcknowledgeMode#INDIVIDUAL_ACKNOWLEDGE}.
+ *
+ * <p>Different JMS providers use different proprietary integer constants
for individual
+ * acknowledgment (e.g., ActiveMQ uses 4, Qpid JMS / ActiveMQ Artemis /
IBM MQ use 101).
Review Comment:
Removed IBM MQ. checked that "IBM MQ use 101" was wrong and fixed
`getAckModeCode` manually before pushing, but forgot to clean up the doc here.
Added description in javadoc
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
