aIbrahiim commented on PR #39351:
URL: https://github.com/apache/beam/pull/39351#issuecomment-5002000136

   > Most of the error looks like below
   > 
   > ```
   > java.lang.reflect.InaccessibleObjectException: Unable to make field 
private final int java.lang.Integer.value accessible: module java.base does not 
"opens java.lang" to unnamed module @7905a0b8
   >    ...
   >    at 
java.base/java.lang.reflect.Field.checkCanSetAccessible(Field.java:183)
   >    at java.base/java.lang.reflect.Field.setAccessible(Field.java:177)
   >    at 
org.apache.beam.runners.dataflow.worker.WindmillStateTestUtils.assertNoReference(WindmillStateTestUtils.java:70)
   > ```
   > 
   > We should fix assertNoReference to handle java.lang primitives. Working on 
it now.
   > 
   > Update: had 
[master...Abacn:beam:assert-no-ref](https://github.com/apache/beam/compare/master...Abacn:beam:assert-no-ref)
 however it seems there are too many Types need to handle. Open modules should 
be fine. Please just add a comment saying it's for 
WindmillStateTestUtils.assertNoReference need to iterate over all references in 
the cache
   
   Thanks for looking into this
   
   Yeah, opening just java.lang isn’t enough as the helper keeps walking the 
cache and then hits other JDK internals (like AtomicReferenceArray and stuff 
under ConcurrentHashMap), so we need a few more --add-opens for java.util, 
java.util.concurrent, and java.util.concurrent.atomic too


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to