bharath000 opened a new pull request, #39378:
URL: https://github.com/apache/beam/pull/39378
fixes #39377
`_MilvusSink.write()` was creating a new `MilvusClient` on every call. But
`__enter__` already creates one (with retry). So the write path threw away the
retried client, made a fresh one without retry, and the old one never got
closed — it just leaks, since `MilvusClient` has no `__del__`. `__exit__` only
closes the last client.
Also the `write()` docstring said it flushes the collection for durability,
but there's no `flush()` call anywhere.
This PR:
- reuses the client from `__enter__` for the upsert instead of building a
new one
- fixes the docstring to describe what actually happens (no flush)
- adds a unit test that checks `write()` reuses the same client (one
created, one closed) with a mocked `MilvusClient`
Follow-up (not here): the sink still opens/closes a connection per batch in
`_flush()`. Moving that to the DoFn `setup()`/`teardown()` would give one
client per worker. Left out to keep this small.
------------------------
Thank you for your contribution! Follow this checklist to help us
incorporate your contribution quickly and easily:
- [x] Mention the appropriate issue in your description (for example:
`addresses #123`), if applicable. This will automatically add a link to the
pull request in the issue. If you would like the issue to automatically close
on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual
Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more
tips on [how to make review process
smoother](https://github.com/apache/beam/blob/master/CONTRIBUTING.md#make-the-reviewers-job-easier).
To check the build health, please visit
[https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more
information about GitHub Actions CI or the [workflows
README](https://github.com/apache/beam/blob/master/.github/workflows/README.md)
to see a list of phrases to trigger workflows.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
