ahmedabu98 commented on code in PR #39344:
URL: https://github.com/apache/beam/pull/39344#discussion_r3608409407
##########
sdks/java/io/google-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryUtilsTest.java:
##########
@@ -1449,17 +1450,27 @@ public void testToBeamRow_timestampMicros_utcSuffix() {
// BigQuery format with " UTC" suffix
String timestamp = "2024-08-10 16:52:07.123456 UTC";
-
- Row beamRow = BigQueryUtils.toBeamRow(schema, new TableRow().set("ts",
timestamp));
-
- java.time.Instant actual = (java.time.Instant) beamRow.getValue("ts");
- assertEquals(2024, actual.atZone(java.time.ZoneOffset.UTC).getYear());
- assertEquals(8, actual.atZone(java.time.ZoneOffset.UTC).getMonthValue());
- assertEquals(10, actual.atZone(java.time.ZoneOffset.UTC).getDayOfMonth());
- assertEquals(16, actual.atZone(java.time.ZoneOffset.UTC).getHour());
- assertEquals(52, actual.atZone(java.time.ZoneOffset.UTC).getMinute());
- assertEquals(7, actual.atZone(java.time.ZoneOffset.UTC).getSecond());
- assertEquals(123456000, actual.getNano());
+ String parsableTimestamp = "2024-08-10T16:52:07.123456Z";
Review Comment:
Done
##########
sdks/java/io/google-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryUtilsTest.java:
##########
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
