gemini-code-assist[bot] commented on code in PR #39393:
URL: https://github.com/apache/beam/pull/39393#discussion_r3617129289


##########
sdks/java/io/cdap/build.gradle:
##########
@@ -90,3 +90,8 @@ test {
     // Open java.lang for Gson reflection on StackTraceElement under Java 17+
     jvmArgs '--add-opens=java.base/java.lang=ALL-UNNAMED'
 }
+
+// spark3_streaming depends on old 'org.lz4:lz4-java'; conflict with 
kafka-clients:3.9.2
+configurations.all {
+    resolveCapabilitiesConflict(it, 'org.lz4:lz4-java', 'at.yawk.lz4')

Review Comment:
   ![high](https://www.gstatic.com/codereviewagent/high-priority.svg)
   
   The module notation 'at.yawk.lz4' is incomplete as it only specifies the 
group ID. It should include the artifact ID as well, which is 
'at.yawk.lz4:lz4-java'. Passing an incomplete module notation will prevent the 
capability conflict resolution helper from correctly identifying and resolving 
the conflict.
   
   ```
       resolveCapabilitiesConflict(it, 'org.lz4:lz4-java', 
'at.yawk.lz4:lz4-java')
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to