Abacn commented on code in PR #39390:
URL: https://github.com/apache/beam/pull/39390#discussion_r3622831292
##########
sdks/java/harness/src/main/java/org/apache/beam/fn/harness/control/ProcessBundleHandler.java:
##########
@@ -767,6 +767,7 @@ public BeamFnApi.InstructionResponse.Builder
trySplit(InstructionRequest request
/** Shutdown the bundles, running the tearDown() functions. */
public void shutdown() throws Exception {
bundleProcessorCache.shutdown();
+ beamFnDataClient.close();
}
Review Comment:
this may be overly defensive. close is always best effort. Currently
`bundleProcessorCache.shutdown()` just invalidates a cache container
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
