jrmccluskey commented on code in PR #39411:
URL: https://github.com/apache/beam/pull/39411#discussion_r3631707395
##########
sdks/python/pyproject.toml:
##########
@@ -127,16 +76,19 @@ exclude = [
"*.pxd",
"*.pyx",
"*pb2*.py",
+ "*.ipynb",
+ "**/*.ipynb",
"**/examples/**/*.py",
"**/examples/**/*.ipynb",
"**/portability/api/**/*.py",
"**/portability/api/__init__.py",
]
target-version = "py310"
src = ["apache_beam"]
+line-length = 120
Review Comment:
This is a carry-over from the fact that our isort configuration has a line
length of 120 to allow for long imports on single lines but our typical
formatting directive is an 80 character line. At the moment ruff doesn't allow
per-linter line length settings (see
https://github.com/astral-sh/ruff/issues/3206) but we also don't use ruff for
formatting, only the linting. yapf is still the tool we use to catch formatting
mismatches (for now) so this shouldn't alter what we allow in the code base
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
