arunpandianp commented on code in PR #38768:
URL: https://github.com/apache/beam/pull/38768#discussion_r3636726827
##########
runners/google-cloud-dataflow-java/worker/src/test/java/org/apache/beam/runners/dataflow/worker/FakeWindmillServer.java:
##########
@@ -445,6 +460,37 @@ public void flush() {
.orElse(Windmill.CommitStatus.OK));
}
requests.clear();
+
+ for (MultiKeyRequestAndDone elem : multiKeyRequests) {
+ if (dropStreamingCommits) {
+ for (WorkItemCommitRequest workRequest :
elem.request.getRequestsList()) {
+ droppedStreamingCommits.put(workRequest.getWorkToken(),
elem.onDone);
+ }
+ continue;
+ }
+
+ multiKeyCommitsReceived.add(elem.request);
+ for (WorkItemCommitRequest workRequest :
elem.request.getRequestsList()) {
+ commitsReceived.put(workRequest.getWorkToken(), workRequest);
+ }
+
+ // Determine status for the batch.
+ // Default to OK, but if any of the works in the batch has an
offered status, use it.
+ Windmill.CommitStatus status = Windmill.CommitStatus.OK;
+ for (WorkItemCommitRequest workRequest :
elem.request.getRequestsList()) {
+ Windmill.CommitStatus offeredStatus =
+ streamingCommitsToOffer.remove(
Review Comment:
Good idea, done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
