scwhittle commented on code in PR #38919:
URL: https://github.com/apache/beam/pull/38919#discussion_r3648578727
##########
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/streaming/Work.java:
##########
@@ -261,20 +337,30 @@ public void queueCommit(WorkItemCommitRequest
commitRequest, ComputationState co
processingContext.workCommitter().accept(Commit.create(commitRequest,
computationState, this));
}
- public WindmillStateReader createWindmillStateReader() {
- return WindmillStateReader.forWork(this);
+ public Consumer<Commit> workCommitter() {
+ return processingContext.workCommitter();
+ }
+
+ public WindmillStateReader createWindmillStateReader(Supplier<Boolean>
workIsFailed) {
+ return WindmillStateReader.forWork(this, workIsFailed);
}
@Override
public WorkId id() {
return id;
}
- public void recordGetWorkStreamLatencies(
- ImmutableList<LatencyAttribution> getWorkStreamLatencies) {
- for (LatencyAttribution latency : getWorkStreamLatencies) {
- totalDurationPerState.put(
- latency.getState(),
Duration.millis(latency.getTotalDurationMillis()));
+ public ImmutableList<LatencyAttribution> getWorkStreamLatencies() {
Review Comment:
Not sure if you sent comments, but I was also suggesting removing the member
variable and public recordGetWorkStreamLatencies method as well. Seems it could
just be done in constructor?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
