derrickaw commented on code in PR #39486:
URL: https://github.com/apache/beam/pull/39486#discussion_r3649093139
##########
.github/workflows/tour_of_beam_backend.yml:
##########
@@ -46,8 +47,7 @@ jobs:
persist-credentials: false
- uses: actions/setup-go@v7
with:
- # pin to the biggest Go version supported by Cloud Functions runtime
- go-version: '1.16'
+ go-version: '1.26.0'
Review Comment:
> shall we preserve the comment above and check if 1.26 is supported by
cloud functions?
Added back the comment and updated it some. I verified earlier that 1.26 was
supported.
> More importantly is there a way to verify this won't break builds
I ran the steps in the workflow.
=== RUN TestParse
--- PASS: TestParse (0.00s)
=== RUN TestSerialize
--- PASS: TestSerialize (0.00s)
=== RUN TestSdkList
--- PASS: TestSdkList (0.00s)
PASS
ok beam.apache.org/learning/tour-of-beam/backend/internal 0.009s
=== RUN TestSample
...
--- PASS: TestSample (0.00s)
=== RUN TestTemplateProcessing
--- PASS: TestTemplateProcessing (0.00s)
PASS
ok beam.apache.org/learning/tour-of-beam/backend/internal/fs_content
0.016s
Does that work? Thanks
##########
.github/workflows/tour_of_beam_backend.yml:
##########
@@ -46,8 +47,7 @@ jobs:
persist-credentials: false
- uses: actions/setup-go@v7
with:
- # pin to the biggest Go version supported by Cloud Functions runtime
- go-version: '1.16'
+ go-version: '1.26.0'
Review Comment:
> shall we preserve the comment above and check if 1.26 is supported by
cloud functions?
Added back the comment and updated it some. I verified earlier that 1.26 was
supported.
> More importantly is there a way to verify this won't break builds
I ran the steps in the workflow.
=== RUN TestParse
--- PASS: TestParse (0.00s)
=== RUN TestSerialize
--- PASS: TestSerialize (0.00s)
=== RUN TestSdkList
--- PASS: TestSdkList (0.00s)
PASS
ok beam.apache.org/learning/tour-of-beam/backend/internal 0.009s
=== RUN TestSample
...
--- PASS: TestSample (0.00s)
=== RUN TestTemplateProcessing
--- PASS: TestTemplateProcessing (0.00s)
PASS
ok beam.apache.org/learning/tour-of-beam/backend/internal/fs_content
0.016s
Does that work? Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
