kamilwu commented on a change in pull request #11856:
URL: https://github.com/apache/beam/pull/11856#discussion_r498156825
##########
File path: sdks/python/apache_beam/testing/load_tests/sideinput_test.py
##########
@@ -27,11 +27,7 @@
* side_input_type (str) - Required. Specifies how the side input will be
materialized in ParDo operation. Choose from (dict, iter, list).
* window_count (int) - The number of fixed sized windows to subdivide the
- side input into. By default, no windows will be used.
- * side_input_size (int) - The size of the side input. Must be equal to or
- lower than the size of the main input. If lower, the side input will be
- created by applying a :class:`beam.combiners.Sample
- <apache_beam.transforms.combiners.Sample>` transform.
+ side input into. By default, a global window will be used.
Review comment:
Isn't it the other way around? Take a look at the constructor, where we
have:
```python
self.get_option_or_default('window_count', default=1)
```
This applies both to the main and the side inputs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
