stankiewicz commented on code in PR #39150:
URL: https://github.com/apache/beam/pull/39150#discussion_r3655628148
##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/pubsub/PubsubIO.java:
##########
@@ -1129,11 +1188,13 @@ public PCollection<T> expand(PBegin input) {
}
if (getDeadLetterTopicProvider() != null
- && !(getBadRecordRouter() instanceof ThrowingBadRecordRouter)) {
+ && (getBadRecordRouter() instanceof ThrowingBadRecordRouter)) {
throw new IllegalArgumentException(
"PubSubIO cannot be configured with both a dead letter topic and a
bad record router");
}
Review Comment:
fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
