Amar3tto commented on code in PR #39457:
URL: https://github.com/apache/beam/pull/39457#discussion_r3675779526
##########
sdks/java/io/debezium/src/main/java/org/apache/beam/io/debezium/DebeziumReadSchemaTransformProvider.java:
##########
@@ -138,10 +150,19 @@ public PCollectionRowTuple expand(PCollectionRowTuple
input) {
readTransform
.withMaxNumberOfRecords(testLimitRecords)
.withMaxTimeToRun(testLimitMilliseconds);
+ } else {
+ Integer maxNumberOfRecords = configuration.getMaxNumberOfRecords();
Review Comment:
I would keep null as “no limit”, and reject zero
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
