shunping commented on PR #39487: URL: https://github.com/apache/beam/pull/39487#issuecomment-5120979525
> Based on the description of the problem, would it make sense to find a way to factor the code so we can have separate streaming/batch implementation of the output counter? The ways they pass elements is just pretty fundamentally different. The difference between the streaming and batch output counters really only matters during the GBK step, specifically regarding what gets wrapped inside `ValueInEmptyWindows`. Per your comment, I updated the PR to separate the implementations. Particularly I subclassed `DataflowOutputCounter` and extracted the specific routine that handles the `window_size == 0` case. PTAL! Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
