tvalentyn commented on code in PR #39288:
URL: https://github.com/apache/beam/pull/39288#discussion_r3683531254
##########
sdks/python/container/boot.go:
##########
@@ -580,10 +581,13 @@ func logRuntimeDependencies(ctx context.Context,
bufLogger *tools.BufferedLogger
}
bufLogger.Printf(ctx, "Dependencies in %s:", phase)
args = []string{"-m", "pip", "freeze", "--all"}
- if err := execx.ExecuteEnvWithIO(nil, os.Stdin, bufLogger, bufLogger,
pythonVersion, args...); err != nil {
+
+ var stdout bytes.Buffer
+ if err := execx.ExecuteEnvWithIO(nil, os.Stdin, &stdout, bufLogger,
pythonVersion, args...); err != nil {
Review Comment:
> Given this distinction, the current ExecuteEnvWithIO and the apis of
BufferedLogger feels pretty clean to me, and I worry that introducing
additional APIs might unnecessarily complicate the interface
Thanks for clarifying.
> This is a good AI summary after all BufferedLogger references are reviewed:
Do you think we should update the docstrings or how-to in the beggining of
the file to mention this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
