Guflly opened a new pull request, #39563:
URL: https://github.com/apache/beam/pull/39563

   Fixes #20642.
   
   The dataframe CSV sink wrapped a binary stream with default newline 
translation, which turned pandas CRLF endings into extra blank lines on 
Windows. Windowed test filenames also used colon-containing timestamps.
   
   This disables newline translation for text sinks and uses the existing 
Windows-safe naming pattern in the windowed test, allowing the full IO test 
class to run on Windows.
   
   Tests:
   - `python -m pytest -q apache_beam\dataframe\io_test.py` (33 passed, 5 
skipped)
   - `python -m yapf --diff apache_beam\dataframe\io.py 
apache_beam\dataframe\io_test.py`
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to