Abacn commented on code in PR #38937:
URL: https://github.com/apache/beam/pull/38937#discussion_r3721933705
##########
model/pipeline/src/main/proto/org/apache/beam/model/pipeline/v1/beam_runner_api.proto:
##########
@@ -1145,6 +1145,9 @@ message StandardCoders {
// encoded with it's corresponding coder.
// Components: single coder for the value
NULLABLE = 17 [(beam_urn) = "beam:coder:nullable:v1"];
+
+ // Coder for Void type. Uses zero bytes per Void.
+ VOID = 19 [(beam_urn) = "beam:coder:void:v1"];
Review Comment:
I'm not recommending expanding standard coder in general. This needs each
SDK (and possibly each runner) to support it. Every time we do so we break
functionalities of certain pipeline in certain runner/sdk - #37631 (for
`beam:coder:schema:v1`); #39623 (for `beam:coder:sharded_key:v1`)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
