chamikaramj commented on code in PR #39617:
URL: https://github.com/apache/beam/pull/39617#discussion_r3723019371


##########
sdks/java/io/expansion-service/build.gradle:
##########
@@ -65,6 +65,7 @@ configurations.runtimeClasspath {
   resolutionStrategy.force 'org.apache.hadoop:hadoop-client:3.3.6'
   resolutionStrategy.force 'org.apache.hadoop:hadoop-hdfs:3.3.6'
   resolutionStrategy.force 'org.apache.hadoop:hadoop-hdfs-client:3.3.6'
+  resolutionStrategy.force 'org.apache.hadoop:hadoop-aws:3.3.6'

Review Comment:
   How much does this increase the `io-expansion-service` jar size by ?



##########
sdks/java/io/delta/build.gradle:
##########
@@ -115,8 +121,21 @@ task dataflowIntegrationTest(type: Test) {
     outputs.upToDateWhen { false }
 
     include '**/*IT.class'
+    exclude '**/DeltaIOS3IT.class'

Review Comment:
   Ah, didn't notice that we had to exclude here. Were you able to verify this 
end-to-end with real S3 data ?
   
   Also, which Github action will pick up this test ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to